Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17 revise set dp and retrieve pa values #18

Merged
merged 5 commits into from
May 1, 2024
Merged

17 revise set dp and retrieve pa values #18

merged 5 commits into from
May 1, 2024

Conversation

funkchaser
Copy link
Collaborator

Resolves #17

@funkchaser funkchaser linked an issue Apr 24, 2024 that may be closed by this pull request
revise: set DP and retrieve PA values #17
Closed
gonzalocasas
gonzalocasas approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/aixd_grasshopper/generate_dataset_rhinoscript.py Outdated Show resolved Hide resolved
src/aixd_grasshopper/gh_ui_helper.py Outdated Show resolved Hide resolved
@funkchaser funkchaser force-pushed the 17-revise-set-dp-and-retrieve-pa-values branch 2 times, most recently from c9442ea to eb0ec98 Compare May 1, 2024 08:56
@funkchaser funkchaser force-pushed the 17-revise-set-dp-and-retrieve-pa-values branch from 32f9810 to eb05ae2 Compare May 1, 2024 09:42
@funkchaser funkchaser merged commit a7bddf3 into main May 1, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzalocasas gonzalocasas gonzalocasas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revise: set DP and retrieve PA values
2 participants
@funkchaser @gonzalocasas