Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend setting WorkingDirectory #1064

Merged
merged 11 commits into from
Jun 1, 2024
Merged

Recommend setting WorkingDirectory #1064

merged 11 commits into from
Jun 1, 2024

Conversation

niusia-ua
Copy link
Member

No description provided.

@niusia-ua niusia-ua requested a review from rojvv May 25, 2024 07:05
Copy link

github-actions bot commented May 25, 2024

@github-actions github-actions bot temporarily deployed to pull request May 25, 2024 07:07 Inactive
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing against these changes. But why don’t we just suggest specifying WorkingDirectory by default? Who wants the working directory of their bot to be like /root, etc.?

@niusia-ua
Copy link
Member Author

niusia-ua commented May 26, 2024

Oh, that's brilliant. I hadn't even thought of that.
In this case, I'll specify the WorkingDirectory and give two ways to load environment variables.
UPD. Although then it's probably better to remove the mention of Environment entirely, because everyone uses the .env file in local development anyway. An additional way to set environment variables will only confuse readers.

@niusia-ua niusia-ua requested a review from rojvv May 26, 2024 08:03
@github-actions github-actions bot temporarily deployed to pull request May 26, 2024 08:05 Inactive
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But the section about the start command should be edited since it is no longer required for the script's path to be absolute.

For example, it can be just

/home/user/.deno/bin/deno run --allow-all mod.ts

NB: You are also missing a run in the Deno example.

@niusia-ua niusia-ua requested a review from rojvv May 30, 2024 05:40
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 05:41 Inactive
site/docs/hosting/vps.md Outdated Show resolved Hide resolved
site/docs/hosting/vps.md Outdated Show resolved Hide resolved
@rojvv rojvv added the ready for translation Translator intervention is required. label May 30, 2024
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 08:09 Inactive
@niusia-ua niusia-ua requested a review from LWJerri May 30, 2024 08:34
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 08:36 Inactive
Copy link
Collaborator

@LWJerri LWJerri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@niusia-ua niusia-ua added the 🇺🇦 UK Modifies or is related to the Ukrainian translations. label May 30, 2024
@quadratz quadratz self-assigned this May 30, 2024
@quadratz quadratz requested a review from KnorpelSenf May 30, 2024 15:38
@quadratz quadratz requested review from LWJerri, rojvv and a user May 30, 2024 15:38
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 18:56 Inactive
@grammyz grammyz added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label May 30, 2024
@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 1, 2024
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 16:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 17:05 Inactive
@ghost ghost added the 🇮🇩 ID Modifies or is related to the Indonesian translations. label Jun 1, 2024
@rojvv rojvv changed the title Add a note about the possibility of using the .env file in systemd Recommend setting WorkingDirectory Jun 1, 2024
@rojvv rojvv added this pull request to the merge queue Jun 1, 2024
Merged via the queue into main with commit 86428f6 Jun 1, 2024
7 of 8 checks passed
@rojvv rojvv deleted the systemd-env branch June 1, 2024 18:26
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 18:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants