Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax highlighting light theme in API ref #1067

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

quadratz
Copy link
Contributor

@quadratz quadratz commented May 29, 2024

The syntax color in the ref docs (dracula-theme) is hard to read in light mode and it does not match the current theme (github-theme). This PQ should resolve the issue.

Before (dracula-theme):
before
After (github-theme):
after

@quadratz quadratz added not translatable Translator intervention is not required. chore Modifies or is related to tooling, configuration, or setup. labels May 29, 2024
Copy link

github-actions bot commented May 29, 2024

@github-actions github-actions bot temporarily deployed to pull request May 29, 2024 11:34 Inactive
@quadratz quadratz marked this pull request as ready for review May 29, 2024 11:46
@quadratz quadratz requested a review from KnorpelSenf May 29, 2024 11:47
@github-actions github-actions bot temporarily deployed to pull request May 29, 2024 11:50 Inactive
@KnorpelSenf
Copy link
Member

it does not match the current theme (github-theme)

And by current theme you mean the current theme for code snippets in light mode for the rest of the website?

Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I had this in mind but never knew what the best practice would be.

@rojvv rojvv changed the title Fix the syntax highlighting color theme in the ref doc Fix syntax highlighting light theme in API ref May 29, 2024
@rojvv rojvv added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 455fbb7 May 29, 2024
14 checks passed
@rojvv rojvv deleted the fix-syntax-color-theme branch May 29, 2024 16:24
@github-actions github-actions bot temporarily deployed to pull request May 29, 2024 16:26 Inactive
@quadratz
Copy link
Contributor Author

And by current theme, you mean the current theme for code snippets in light mode for the rest of the website?

Yes. Previously, it only used one theme, which was designed for dark mode only. Now it should use two different themes for both light mode and the dark mode, like we already do with the rest of the website.

@quadratz
Copy link
Contributor Author

quadratz commented May 29, 2024

Thank you so much! I had this in mind but never knew what the best practice would be.

I also feel uncomfortable with hardcoding the color values. It should be done dynamically. But at least this is what we can do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Modifies or is related to tooling, configuration, or setup. not translatable Translator intervention is not required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants