-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax highlighting light theme in API ref #1067
Conversation
🚀 Deployed on https://66575707a00be63bd8624bd6--grammy.netlify.app |
And by current theme you mean the current theme for code snippets in light mode for the rest of the website? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! I had this in mind but never knew what the best practice would be.
Yes. Previously, it only used one theme, which was designed for dark mode only. Now it should use two different themes for both light mode and the dark mode, like we already do with the rest of the website. |
I also feel uncomfortable with hardcoding the color values. It should be done dynamically. But at least this is what we can do for now. |
The syntax color in the ref docs (dracula-theme) is hard to read in light mode and it does not match the current theme (github-theme). This PQ should resolve the issue.
Before (dracula-theme):
After (github-theme):