Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about allowed_updates to the menu plugin page #1069

Merged
merged 7 commits into from
Jun 1, 2024
Merged

Add note about allowed_updates to the menu plugin page #1069

merged 7 commits into from
Jun 1, 2024

Conversation

KnorpelSenf
Copy link
Member

@KnorpelSenf KnorpelSenf commented May 29, 2024 •
edited
Loading

Supersedes and thus closes #1068.

  • allowed updates can be specified not only for bot.start() but also for webhooks and with grammY runner
  • this should only be an optional note (not a text paragraph), most people don't configure this
  • we already have a note about callback query updates in the middleware system, so it makes sense to put these two hints close to each other

@KnorpelSenf KnorpelSenf mentioned this pull request May 29, 2024
Closed
@KnorpelSenf
Copy link
Member Author

Approval in #1068 (comment)

@KnorpelSenf KnorpelSenf requested a review from rojvv May 29, 2024 13:08
@KnorpelSenf KnorpelSenf changed the title add note about allowed_updates Add note about allowed_updates to the menu plugin page May 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

🚀 Deployed on https://665b53d7979a3edb10b1f10c--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 29, 2024 13:10 Inactive
@rojvv rojvv added the ready for translation Translator intervention is required. label May 29, 2024
@grammyz grammyz added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label May 29, 2024
@github-actions github-actions bot temporarily deployed to pull request May 29, 2024 17:08 Inactive
@quadratz quadratz self-assigned this May 30, 2024
@niusia-ua niusia-ua added the 🇺🇦 UK Modifies or is related to the Ukrainian translations. label May 30, 2024
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 05:33 Inactive
@quadratz quadratz requested review from rojvv and a user May 30, 2024 15:05
@github-actions github-actions bot temporarily deployed to pull request May 30, 2024 15:06 Inactive
@quadratz quadratz removed the request for review from rojvv May 30, 2024 15:42
@ghost ghost added the 🇮🇩 ID Modifies or is related to the Indonesian translations. label May 31, 2024
@github-actions github-actions bot temporarily deployed to pull request May 31, 2024 11:48 Inactive
@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 1, 2024
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 15:46 Inactive
@rojvv rojvv added this pull request to the merge queue Jun 1, 2024
Merged via the queue into main with commit 4230e09 Jun 1, 2024
5 checks passed
@rojvv rojvv deleted the allowed-updates-for-menu branch June 1, 2024 17:00
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 17:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojvv rojvv rojvv approved these changes

@habemuscode habemuscode habemuscode approved these changes

Assignees

@quadratz quadratz

Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KnorpelSenf @habemuscode @rojvv @quadratz @niusia-ua @grammyz