Implement set_scaling and stop_scaling JAX primitives.
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balancap
force-pushed
the
implement-set-stop-scaling-primitives
branch
4 times, most recently
from
e5eb23d
to
a91c734
Compare
* `set_scaling`: Set the scaling of a tensor, transforming into `ScaledArray` in `autoscale` mode. * `stop_scaling`: Stop scale propagation of a tensor, transforming back into a JAX array. Both operations are no-op identity operations in normal JAX mode. Note: as pointed by @DouglasOrr, these primitives could also be formalized as casting operations, where ScaledDtypes are properly defined. To be clarified whether it may be a better setting for the JAX implementation!
balancap
force-pushed
the
implement-set-stop-scaling-primitives
branch
from
a91c734
to
07df3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_scaling: Set the scaling of a tensor, transforming intoScaledArrayinautoscalemode.stop_scaling: Stop scale propagation of a tensor, transforming back into a JAX array.Both operations are no-op identity operations in normal JAX mode.
Note: as pointed by @DouglasOrr, these primitives could also be formalized as casting operations, where
ScaledDtypesare properly defined. To be clarified whether it may be a better setting for the JAX implementation!