fix(uploader): guard against potential null deref in exn handler

graphistry · Oct 12, 2023 · d3e1a27 · d3e1a27
1 parent db31c0a
commit d3e1a27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 * Memgraph: Add tutorial (https://github.com/graphistry/pygraphistry/pull/507 by https://github.com/karmenrabar)
 
+### Fixed
+
+* Guard against potential `requests`` null dereference in uploader error handling
+
 ## [0.29.5 - 2023-08-23]
 
 ### Fixed

diff --git a/graphistry/arrow_uploader.py b/graphistry/arrow_uploader.py
@@ -656,7 +656,7 @@ def post_arrow(self, arr: pa.Table, graph_type: str, opts: str = ''):
                 raise Exception('No success indicator in server response')
             return out
         except requests.exceptions.HTTPError as e:
-            logger.error('Failed to post arrow to %s (%s)', sub_path, e.request.url, exc_info=True)
+            logger.error('Failed to post arrow to %s (%s)', sub_path, e.request.url if e.request is not None else "(No request)", exc_info=True)
             logger.error('%s', e)
             logger.error('%s', e.response.text)
             raise e