Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up notebooks added to gfql demo folder, readme update #559

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

cleaned up notebooks added to gfql demo folder, readme update #559

wants to merge 6 commits into from

Conversation

dcolinmorgan
Copy link
Contributor

No description provided.

lmeyerov
lmeyerov reviewed Jul 5, 2024
View reviewed changes
demos/gfql/gfql_cpv_gpu_enchmark.ipynb Outdated
@@ -0,0 +1,2976 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of making a new file & url, replace the old file

(and revert any changed links)

lmeyerov
lmeyerov reviewed Jul 10, 2024
View reviewed changes
README.md Outdated
@@ -147,7 +147,7 @@ It is easy to turn arbitrary data into insightful graphs. PyGraphistry comes wit
g2.plot()
```

* GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb))
* GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [chain and hop demo](demos/gfql/simple_gfql_notebook.ipynb), [benchmark](demos/gfql/gfql_cpv_gpu_enchmark.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lingering stale edit?

lmeyerov
lmeyerov reviewed Jul 10, 2024
View reviewed changes
README.md Outdated
@@ -1248,7 +1248,7 @@ assert 'pagerank' in g2._nodes.columns

PyGraphistry supports GFQL, its PyData-native variant of the popular Cypher graph query language, meaning you can do graph pattern matching directly from Pandas dataframes without installing a database or Java

See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb) and the CPU/GPU [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb)
See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [starting with chain and hop](demos/gfql/simple_gfql_notebook.ipynb) and the CPU/GPU [benchmark](demos/gfql/gfql_cpv_gpu_enchmark.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lingering stale edit?

lmeyerov
lmeyerov requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix dangling links from stale edit and that's it!

lmeyerov
lmeyerov reviewed Jul 15, 2024
View reviewed changes
README.md Outdated
@@ -147,7 +147,7 @@ It is easy to turn arbitrary data into insightful graphs. PyGraphistry comes wit
g2.plot()
```

* GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb))
* GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb),[benchmark](demos/gfql/gfql_hops_cpu_gpu.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be changed, should still be old benchmark_hops_cpu_gpu, not gfql_...

lmeyerov
lmeyerov reviewed Jul 15, 2024
View reviewed changes
README.md
@@ -1248,7 +1248,7 @@ assert 'pagerank' in g2._nodes.columns

PyGraphistry supports GFQL, its PyData-native variant of the popular Cypher graph query language, meaning you can do graph pattern matching directly from Pandas dataframes without installing a database or Java

See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb) and the CPU/GPU [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb)
See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), and the CPU/GPU [benchmark](demos/gfql/gfql_hops_cpu_gpu.ipynb)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem here

lmeyerov
lmeyerov requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@lmeyerov lmeyerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • still need to back out readme.md url changes
  • readme.md has conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmeyerov lmeyerov lmeyerov requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dcolinmorgan dcolinmorgan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcolinmorgan @lmeyerov