Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle underflow error #322

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: handle underflow error #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/graphcast_agent/message_typing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,19 @@ impl<T: RadioPayload> GraphcastMessage<T> {

/// Check timestamp: prevent past message replay
pub fn valid_time(&self) -> Result<&Self, MessageError> {
//Can store for measuring overall Graphcast message latency
let message_age = Utc::now().timestamp() as u64 - self.nonce;
// 0 allow instant atomic messaging, use 1 to exclude them
if (0..MSG_REPLAY_LIMIT).contains(&message_age) {
Ok(self)
} else {
Err(MessageError::InvalidFields(anyhow!(
let current_time = Utc::now().timestamp();
let current_time_u64 = current_time as u64;

match current_time_u64.checked_sub(self.nonce) {
Some(message_age) if (0..MSG_REPLAY_LIMIT).contains(&message_age) => Ok(self),
Some(message_age) => Err(MessageError::InvalidFields(anyhow!(
"Message timestamp {} outside acceptable range {}, drop message",
message_age,
MSG_REPLAY_LIMIT
)))
))),
None => Err(MessageError::InvalidFields(anyhow!(
"Error calculating message age, possible underflow."
))),
}
}

Expand Down
Loading