Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing pipeline #8

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Processing pipeline #8

wants to merge 8 commits into from

Conversation

juanmardefago
Copy link
Collaborator

No description provided.

@juanmardefago juanmardefago mentioned this pull request Aug 21, 2024
Open
@chriswessels chriswessels requested a review from i0n August 30, 2024 12:38
i0n
i0n requested changes Sep 3, 2024
View reviewed changes
Copy link

@i0n i0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general rule I think it’s best we head towards rust code that compiles without warnings.

oracle/datasource/src/logs.rs Outdated Show resolved Hide resolved
oracle/datasource/src/processing.rs Outdated Show resolved Hide resolved
oracle/datasource/src/processing.rs Outdated Show resolved Hide resolved
oracle/datasource/src/processing.rs Outdated Show resolved Hide resolved
oracle/migration/src/m20230416_185838_create_table_client_query_result.rs Outdated Show resolved Hide resolved
oracle/migration/src/m20240723_133527_create_table_indexer_attempts.rs Outdated Show resolved Hide resolved
oracle/src/main.rs Outdated Show resolved Hide resolved
@juanmardefago
Copy link
Collaborator Author

As a general rule I think it’s best we head towards rust code that compiles without warnings.

I agree, I think I forgot to make to do a cleanup after all the trial and error to make it work, but glad you pointed it out!
Will fix this once I'm back on QoS Oracle work

@juanmardefago
Copy link
Collaborator Author

@i0n fixed all warnings you mentioned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswessels chriswessels Awaiting requested review from chriswessels

@sahra-karakoc sahra-karakoc Awaiting requested review from sahra-karakoc

@i0n i0n Awaiting requested review from i0n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanmardefago @i0n