Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fixes #5

Merged
merged 2 commits into from
Jul 19, 2023
Merged

quick fixes #5

merged 2 commits into from
Jul 19, 2023

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Jul 18, 2023

Description

  • Message type added as a label for validated messages metrics
  • Cached messages renamed to be specific to PublicPoiMessage
  • Since self setup is validated initialization, the supplied indexer_address can be used directly when serving the response to comparisonRatios

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen added the bug label Jul 18, 2023
@hopeyen hopeyen requested a review from pete-eiger July 18, 2023 15:40
@hopeyen hopeyen self-assigned this Jul 18, 2023
Copy link
Contributor

@pete-eiger pete-eiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff!

@hopeyen hopeyen merged commit 2c3a747 into dev Jul 19, 2023
@hopeyen hopeyen deleted the hope/metrics-fix branch July 19, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants