Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdlToSchema to public API #332

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jul 6, 2023

Thanks for this tool!

Motivated by #238 (comment), this strawman exports sdlToIntrospection.

A concrete use case for this is when a live server is not readily accessible, but an SDL is available.

A more sweeping approach would be to also ship an intermediate lib such that a downstream could:

import { sdlToIntrospection } from 'graphql-voyager/lib/utils/sdl-to-introspection';

@LunaticMuch LunaticMuch self-requested a review July 13, 2023 07:24
@LunaticMuch
Copy link
Collaborator

@bollwyvl you need to rebase. In version 2.0 the function is now sdlToSchema

Copy link
Collaborator

@LunaticMuch LunaticMuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase required

@bollwyvl bollwyvl changed the title Add sdlToIntrospection to public API Add sdlToSchema to public API Sep 1, 2023
@bollwyvl
Copy link
Contributor Author

@LunaticMuch thoughts?

@optimistex
Copy link

@LunaticMuch Current changes are correct. Can you please merge it?
@bollwyvl FYI

@LunaticMuch LunaticMuch self-requested a review January 24, 2024 20:41
@LunaticMuch LunaticMuch merged commit 55575b2 into graphql-kit:main Jan 24, 2024
9 checks passed
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants