Upgrade to Graphene v3 #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same has been done in graphene.
Python 3 bundles mock in stdlib.
Allow for some flexibility on version numbers.
As we're targeting Python >= 3.6, this module should always be in stdlib.
SQLAlchemy 1.4+ does not export Binary directly. We should decide whether to keep this test, update for another unknown type, or remove it altogether.
Closed
|
Any updates on this? It would be really helpful if this can get merged. |
8 tasks
|
Any updates on this? This is currently one of only two remaining blockers for releasing Graphene v3. |
Merged
Closed
|
This is now obsolete in light of #317 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on excellent work by @DoctorJohn (#296) and brings us one step closer to compatibility with graphene 3.0. The only failing tests now should all relate to batching.
See #248 for the main issue and discussion.