Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GraphiQL to 3.0.5 version (#1069) #1188

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Upgrade GraphiQL to 3.0.5 version (#1069) #1188

merged 5 commits into from
Sep 13, 2023

Conversation

tyranron
Copy link
Member

@tyranron tyranron commented Sep 13, 2023 •
edited
Loading

Extends #1069
Fixes #1183

Synopsis

See #1069 (comment):

GraphiQL and GraphQL Playground updates go fully unnoticed for us. I think it's time do to something about it.

It would be nice to add a package.json manifest to the repository with a versions range of GraphiQL and GraphQL Playground (along with the yarn.lock file), where in the post-install stage we copy the sources of GraphiQL/GraphQL Playground to juniper/src/ dir, and in the code we use include_str!() at the propriate places.

Finally, we make dependabot to look after GraphiQL/GraphQL Playground updates for us.

Solution

Introduces package.json which tracks graphiql versions, and a simple toolchain downloading and adopting actual integration files.

Additionally

Updates example_warp_subscriptions for show-case of new GraphiQL with subscriptions.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file labels Sep 13, 2023
@tyranron tyranron added this to the 0.16.0 milestone Sep 13, 2023
@tyranron tyranron self-assigned this Sep 13, 2023
@tyranron tyranron marked this pull request as ready for review September 13, 2023 14:31
@tyranron tyranron merged commit f9d9027 into master Sep 13, 2023
200 checks passed
@tyranron tyranron deleted the upgrade-graphiql branch September 13, 2023 15:34
@tyranron tyranron mentioned this pull request Sep 13, 2023
Merged
@tyranron tyranron mentioned this pull request Oct 27, 2023
Closed
@tyranron tyranron added k::integration Related to integration with third-party libraries or systems javascript Related to Javascript specifically lib::graphiql Related to GraphiQL integration labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tyranron tyranron

Labels
enhancement Improvement of existing features or bugfix javascript Related to Javascript specifically k::dependencies Pull requests that update a dependency file k::integration Related to integration with third-party libraries or systems lib::graphiql Related to GraphiQL integration
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

A better way to keep graphiql updated
1 participant
@tyranron