Remove iron integration
#1210
Merged
Remove iron integration
#1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranron
added
k::documentation
|
@LegNeato before merging this, I would like to hear any comments of yours on this, if you have ones to share. |
|
I think this is the right call! I doubt anyone is using iron anymore, and if they are they can use old versions or add a pr and sign up to support it themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
juniper_ironcrate from workspace, and thus, support for theironcrate for futurejuniperversions.Motivation
ironcrate seems to become unmaintained and unsupported for a while, confirmed by its authors:It also depends on quite old versions, introducing regular problems to CI.
Support criteria
Once
ironcrate becomes actively maintained again and supports latest versions of its dependencies, it would be easy to restorejuniper_ironcrate back into the workspace and maintain it.