Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy look_ahead #1212

Merged
merged 16 commits into from
Jan 16, 2024
Merged

Lazy look_ahead #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cc3d84d
refactor(breaking): Rewrite look_ahead to use lazy computation
audunhalland Nov 11, 2023
545ad9b
refactor: Simplify
audunhalland Nov 12, 2023
69c8cc4
chore: Small documentation improvements
audunhalland Nov 12, 2023
cf244ac
refactor: Rename ChildrenBuilder methods into something hopefully mor…
audunhalland Nov 12, 2023
fd7b322
fix: Bring back LookAheadSelection::argument
audunhalland Nov 13, 2023
b1d9a07
fix: Avoid capturing the &self lifetime in impl Iterators unless requ…
audunhalland Nov 13, 2023
855f5a6
fix: arguments API
audunhalland Jan 11, 2024
33d39a5
feat: impl IntoIterator for LookAheadList and LookAheadObject
audunhalland Jan 11, 2024
f7618b1
`.cloned()` -> `.copied()`
tyranron Jan 12, 2024
2e57825
Use `BorrowedSpanning`
tyranron Jan 12, 2024
61bc211
fix: Copy impl for LookAheadValue, LookAheadList, LookAheadObject
audunhalland Jan 13, 2024
771a030
fix: Add doc notes about lazy iterators / impl DoubleEndedIterator
audunhalland Jan 15, 2024
68d0d14
chore: Integrate look_ahead_lazy (work in progress)
audunhalland Nov 14, 2023
6b31f12
chore: Replace look_ahead with new implementation
audunhalland Jan 15, 2024
c8202c5
Polishing
tyranron Jan 16, 2024
8bd5eaf
Mention in CHANGELOG
tyranron Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/src/types/interfaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ This requires to explicitly parametrize over [`ScalarValue`][3], as [`Executor`]

```rust
# extern crate juniper;
use juniper::{graphql_interface, graphql_object, Executor, LookAheadMethods as _, ScalarValue};
use juniper::{graphql_interface, graphql_object, Executor, ScalarValue};

#[graphql_interface(for = Human, Scalar = S)] // notice specifying `ScalarValue` as existing type parameter
trait Character<S: ScalarValue> {
Expand Down
18 changes: 14 additions & 4 deletions juniper/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,22 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
- Removed `scalar-naivetime` [Cargo feature].
- Removed lifetime parameter from `ParseError`, `GraphlQLError`, `GraphQLBatchRequest` and `GraphQLRequest`. ([#1081], [#528])
- Upgraded [GraphiQL] to 3.1.0 version (requires new [`graphql-transport-ws` GraphQL over WebSocket Protocol] integration on server, see `juniper_warp/examples/subscription.rs`). ([#1188], [#1193], [#1235])
- Made `LookAheadMethods::children()` method to return slice instead of `Vec`. ([#1200])
- Abstracted `Spanning::start` and `Spanning::end` fields into separate struct `Span`. ([#1207], [#1208])
- Added `Span` to `Arguments` and `LookAheadArguments`. ([#1206], [#1209])
- Removed `graphql-parser-integration` and `graphql-parser` [Cargo feature]s by merging them into `schema-language` [Cargo feature]. ([#1237])
- Renamed `RootNode::as_schema_language()` method as `RootNode::as_sdl()`. ([#1237])
- Renamed `RootNode::as_parser_document()` method as `RootNode::as_document()`. ([#1237])
- Renamed `RootNode::as_parser_document()` method as `RootNode::as_document()`. ([#1237])
- Reworked look-ahead machinery: ([#1212])
- Turned from eagerly-evaluated into lazy-evaluated:
- Made `LookAheadValue::List` to contain new iterable `LookAheadList` type.
- Made `LookAheadValue::Object` to contain new iterable `LookAheadObject` type.
- Removed `LookAheadMethods` trait and redundant `ConcreteLookAheadSelection` type, making all APIs accessible as inherent methods on `LookAheadSelection` and `LookAheadChildren` decoupled types:
- Moved `LookAheadMethods::child_names()` to `LookAheadChildren::names()`.
- Moved `LookAheadMethods::has_children()` to `LookAheadChildren::is_empty()`.
- Moved `LookAheadMethods::select_child()` to `LookAheadChildren::select()`.
- Moved `LookAheadSelection::for_explicit_type()` to `LookAheadSelection::children_for_explicit_type()`.
- Made `LookAheadSelection::arguments()` returning iterator over `LookAheadArgument`.
- Made `LookAheadSelection::children()` returning `LookAheadChildren`.
- Added `Span` to `Arguments` and `LookAheadArguments`. ([#1206], [#1209])

### Added

Expand Down Expand Up @@ -145,11 +155,11 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
[#1190]: /../../pull/1190
[#1193]: /../../pull/1193
[#1199]: /../../pull/1199
[#1200]: /../../pull/1200
[#1206]: /../../pull/1206
[#1207]: /../../pull/1207
[#1208]: /../../pull/1208
[#1209]: /../../pull/1209
[#1212]: /../../pull/1212
[#1215]: /../../pull/1215
[#1227]: /../../pull/1227
[#1228]: /../../pull/1228
Expand Down
Loading