Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:Unexpected duplicate "display". #3439

Merged
merged 3 commits into from
Nov 20, 2023
Merged

FIX:Unexpected duplicate "display". #3439

merged 3 commits into from
Nov 20, 2023

Conversation

xonx4l
Copy link
Contributor

@xonx4l xonx4l commented Oct 16, 2023

ISSUE-:#2896

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

🦋 Changeset detected

Latest commit: 766ade0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/plugin-code-exporter Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove first display

@acao
Copy link
Member

acao commented Oct 25, 2023

@xonx4l thanks for this - three things:

  1. i think you need to remove display: block above instead as @dimaMachina noted
  2. can you add a changeset with patch as per the comment?
  3. can you sign the CLA, and make sure your commit is signed with the same email you signed the CLA with?

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #3439 (766ade0) into main (2348641) will increase coverage by 0.10%.
Report is 30 commits behind head on main.
The diff coverage is 79.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3439      +/-   ##
==========================================
+ Coverage   55.75%   55.85%   +0.10%     
==========================================
  Files         110      110              
  Lines        5243     5264      +21     
  Branches     1426     1435       +9     
==========================================
+ Hits         2923     2940      +17     
- Misses       1897     1898       +1     
- Partials      423      426       +3     
Files Coverage Δ
packages/graphiql-react/src/editor/context.tsx 73.39% <100.00%> (ø)
...raphql-language-service-server/src/GraphQLCache.ts 50.88% <50.00%> (ø)
...ql-language-service-server/src/MessageProcessor.ts 46.11% <50.00%> (-0.11%) ⬇️
...nguage-service/src/utils/getVariablesJSONSchema.ts 94.59% <98.38%> (+0.71%) ⬆️
packages/graphiql/src/components/GraphiQL.tsx 68.96% <0.00%> (-0.97%) ⬇️
packages/graphiql-react/src/editor/hooks.ts 40.15% <23.52%> (+1.56%) ⬆️

@acao
Copy link
Member

acao commented Nov 20, 2023

@xonx4l thanks so much! good to go!

@acao acao merged commit d07d5fc into graphql:main Nov 20, 2023
14 checks passed
@acao acao mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants