[v12] Remove unused FIPS infrastructure #32540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIPS is only built on amd64, and only on our centos:7 buildboxes. These other dockerfiles and targets are vestigial. Furthermore, the buildbox is a security risk, as ubuntu:18.04 is not supported after 2023-05-31. If/when we want to support FIPS on ARM, we can build off the centos:7 infrastructure, or its successor. (cherry picked from commit fafa16a)
* Remove Dockerfile-arm-fips We don't build fips for arm, as documented in #10581. * Stop building buildbox-fips We do not use this buildbox for anything. This step is failing because the supporting infrastructure for buildbox-fips was removed in #26859. * Fix fips buildbox BUILDBOX_FIPS was removed, replaced by BUILDBOX_CENTOS7_FIPS. Unfortunately I missed updating this target in #26859. This subsequently broke e CI. (cherry picked from commit 6ef1186)
mdwn
approved these changes
Sep 26, 2023
Everything looks good to me. Thanks for your dilligence in backporting all this. |
wadells
approved these changes
Sep 26, 2023
zmb3
approved these changes
Sep 26, 2023
public-teleport-github-review-bot
bot
removed request for
tcsc,
jakule and
fheinecke
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26859 and #27900
Currently, push builds fail on v12 because the job
Build and push buildbox-fipsfails. It happens since we upgraded Node.js (Ubuntu 18.04 doesn't support Node 18). The easiest fix would be to just remove installing Node, but IMO since we have completely removed the infrastructure on master, we can do it here as well, since it seems to be unused (or maybe it isn't?).Additionally, the pipeline uses Ubuntu 18.04 which is no longer supported.
e counterpart https://github.com/gravitational/teleport.e/pull/2299
I ran a drone tag build, it's green https://drone.platform.teleport.sh/gravitational/teleport/28873.
@wadells could you look if I didn't miss anything here?