-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VerticalLayout): remove div element causing flex issues #101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 74.85% 74.80% -0.05%
==========================================
Files 38 38
Lines 505 504 -1
Branches 96 96
==========================================
- Hits 378 377 -1
Misses 90 90
Partials 37 37 ☔ View full report in Codecov by Sentry. |
852b35b
to
a406e26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the label in vertical layout needs to be removed altogether; our types don't even allow vertical layout labels to be specified
831d64c
to
29848b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 1.21.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Unlike the
HorzontalLayout
theVerticalLayout
was submittingdiv
as the component prop to the antdForm
component. This causes an issue with container heights, overflow and margin collapse when attempting to use thevertical
layout prop in either forms or form items.For instance, if one updates the StorybookAntDJsonForm like so:
The resulting issues can be seen in all stories featuring the
VerticalLayout
renderer:however, the same issue is not present in the
HorizontalLayout
After investigation this appears to have been caused by the
component
prop being supplied toForm
in the Vertical layout being a div rather thanfalse
as it is inHorizontalLayout
. This update brings parity to the two components in terms of dom structure expectations and fixes the issues with vertical forms.