Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up semantic release #20

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: set up semantic release #20

merged 2 commits into from
Mar 11, 2024

Conversation

DrewHoo
Copy link
Contributor

@DrewHoo DrewHoo commented Mar 4, 2024

No description provided.

Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a basic README blurb about how this works? Even if it's just a link to the semantic-release docs (here?). It will ultimately pull from the PR title right? We have this stage to enforce the title format in GX.

@DrewHoo
Copy link
Contributor Author

DrewHoo commented Mar 4, 2024

Can we add a basic README blurb about how this works? Even if it's just a link to the semantic-release docs (here?). It will ultimately pull from the PR title right? We have this stage to enforce the title format in GX.

@NathanFarmer yes, as soon as it works 😂 -- can you approve this with the understanding that I'm iterating to the point of documenting the working result?

@@ -1,7 +1,7 @@
{
"name": "@great-expectations/jsonforms-antd-renderers",
"private": false,
"version": "0.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this version increase automatic? Does this tell me that it is working?

@DrewHoo DrewHoo merged commit ec1263d into main Mar 11, 2024
2 of 3 checks passed
@DrewHoo DrewHoo deleted the f/publish-the-package-2 branch March 11, 2024 15:56
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants