feat(CA1825): upgrade CA1825 severity to warning (#55)

Directory.Build.props

@@ -29,4 +29,8 @@
 	<ItemGroup>
 		<Compile Include="..\..\SharedAssemblyInfo.cs" Link="Properties\SharedAssemblyInfo.cs" />
 	</ItemGroup>
+
+	<ItemGroup>
+		<GlobalAnalyzerConfigFiles Include="$(MSBuildThisFileDirectory)\src\EcoCode.Package\EcoCode.globalconfig" />
+	</ItemGroup>
 </Project>

README.md

@@ -28,11 +28,11 @@ There are several ways you can use the ecoCode analyzers in your .Net projects:
 
 Both the EcoCode NuGet package and Visual Studio extension target .Net Standard 2.0 and can be used in a wide range of projects. See [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version) for details about the supported .Net Frameworks in .Net Standard 2.0.
 
-🌿 Rules
+🌿 EcoCode Rules
 -------------------
 
 |Id|Description|Severity|Enabled|Code fix|
-|--|-----------|:------:|:--------:|:------:|
+|--|-----------|:------:|:-----:|:------:|
 |[EC69](https://github.com/green-code-initiative/ecoCode/blob/main/ecocode-rules-specifications/src/main/rules/EC69/csharp/EC69.asciidoc)|Don’t call loop invariant functions in loop conditions|⚠️|✔️|❌|
 |[EC72](https://github.com/green-code-initiative/ecoCode/blob/main/ecocode-rules-specifications/src/main/rules/EC72/csharp/EC72.asciidoc)|Don’t execute SQL queries in loops|⚠️|✔️|❌|
 |[EC75](https://github.com/green-code-initiative/ecoCode/blob/main/ecocode-rules-specifications/src/main/rules/EC75/csharp/EC75.asciidoc)|Don’t concatenate `strings` in loops|⚠️|✔️|❌|
@@ -45,6 +45,15 @@ Both the EcoCode NuGet package and Visual Studio extension target .Net Standard
 |[EC87](https://github.com/green-code-initiative/ecoCode/blob/main/ecocode-rules-specifications/src/main/rules/EC87/csharp/EC87.asciidoc)|Use collection indexer|⚠️|✔️|✔️|
 |[EC88](https://github.com/green-code-initiative/ecoCode/blob/main/ecocode-rules-specifications/src/main/rules/EC88/csharp/EC88.asciidoc)|Dispose resource asynchronously|⚠️|✔️|✔️|
 
+🌿 Roslyn Rules
+-------------------
+
+This plugin customizes the severity of certain Roslyn rules.
+
+|Id|Description|Old Severity|New Severity|Enabled|Code fix|
+|--|-----------|:----------:|:----------:|:-----:|:------:|
+|[CA1825](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1825)|Avoid zero-length array allocations|ℹ️|⚠️|✔️|✔️|
+
 🤝 Contribution
 ---------------
 

src/EcoCode.Package/EcoCode.Package.csproj

@@ -40,6 +40,8 @@
 
 	<ItemGroup>
 		<None Include="..\EcoCode.Core\bin\$(Configuration)\$(TargetFramework)\EcoCode.Core.dll" Pack="true" PackagePath="analyzers/dotnet/cs" />
+		<None Include="EcoCode.globalconfig" Pack="true" PackagePath="analyzers/config" CopyToOutputDirectory="PreserveNewest" />
+		<None Include="EcoCode.props" Pack="true" PackagePath="build" CopyToOutputDirectory="PreserveNewest" />
 	</ItemGroup>
 
 	<ItemGroup>

src/EcoCode.Package/EcoCode.globalconfig

@@ -0,0 +1,4 @@
+is_global = true
+
+# CA1825: Avoid zero-length array allocations
+dotnet_diagnostic.CA1825.severity = warning

src/EcoCode.Package/EcoCode.props

@@ -0,0 +1,5 @@
+<Project>
+	<ItemGroup>
+		<GlobalAnalyzerConfigFiles Include="$(MSBuildThisFileDirectory)../analyzers/config/EcoCode.globalconfig" />
+	</ItemGroup>
+</Project>