Add new rule EC31: Prefer lighter formats for image files #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salah-dev-inp
force-pushed
the
EC31-prefer-lighter-formats-for-image-file
branch
from
4a61b04 to
b69c5f3
Compare
dedece35
requested changes
Jun 13, 2024
|
|
||
| ### Deleted | ||
| ## [1.6.2] - 2024-05-30 |
There was a problem hiding this comment.
why do you add this section title ?
please remove it and let your new line added under "Unreleased" section
| import org.sonar.api.utils.log.Loggers; | ||
|
|
||
| @Rule(key = "EC31") | ||
| @DeprecatedRuleKey(repositoryKey = "greencodeinitiative-java", ruleKey = "EC31") |
| if (tree.is(Tree.Kind.STRING_LITERAL)) { | ||
| LiteralTree literalTree = (LiteralTree) tree; | ||
| String value = literalTree.value(); | ||
|
|
There was a problem hiding this comment.
her, you can "return" empty if your string length is not > 6 (because the minimum length is 7 for your image name is : "a.png"
thus no need to execute the next if and the next for of the algorithm, for nothing.
| public PreferLighterImageFormatsCheck(PreferLighterImageFormatsCheck checker) { | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
add a use case test with my review feedback above => no need to check if string length isn't > 6
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.