Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHALLENGE24][EC1044] : Use every column queried #63

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

max-208
Copy link

@max-208 max-208 commented Aug 19, 2024

created in mostly during the ecocode challenge 2024, this rule aims to avoid doing sql queries and not using selected columns. rule specification here

Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

thank you for your PR !!!
some feedbacks :

  • could you rename each test java file (inside "src/test/files") with a functional name ? like that a developer knows the content and the purpose of each class. If you can add javadoc for more explanations before de the class name, please ?
  • What is the behaviour with a use case like "SELECT * FROM toto" ? can you add this use case test, please ?

Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a PR inside "ecoCode-java-test-project" repository with your test classes ... can you do it please ?

please check documentation https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#implement-a-new-rule and specifically the "DoD" part to check all mandatories developments are done, please.

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug 🏆 challenge 🏆 Work done during the ecoCode Challenge labels Sep 6, 2024
@max-208
Copy link
Author

max-208 commented Sep 9, 2024

here is the pr in ecocode-java-test-project

@max-208 max-208 requested a review from dedece35 September 11, 2024 07:32
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 12, 2024
@github-actions github-actions bot removed the stale label Oct 19, 2024
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 18, 2024
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@github-actions github-actions bot removed the stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug 🏆 challenge 🏆 Work done during the ecoCode Challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants