-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHALLENGE24][EC1044] : Use every column queried #63
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
thank you for your PR !!!
some feedbacks :
- could you rename each test java file (inside "src/test/files") with a functional name ? like that a developer knows the content and the purpose of each class. If you can add javadoc for more explanations before de the class name, please ?
- What is the behaviour with a use case like "SELECT * FROM toto" ? can you add this use case test, please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a PR inside "ecoCode-java-test-project" repository with your test classes ... can you do it please ?
please check documentation https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#implement-a-new-rule and specifically the "DoD" part to check all mandatories developments are done, please.
src/main/java/fr/greencodeinitiative/java/checks/UseEveryColumnQueried.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/greencodeinitiative/java/checks/UseEveryColumnQueried.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/greencodeinitiative/java/checks/UseEveryColumnQueried.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/greencodeinitiative/java/checks/UseEveryColumnQueried.java
Show resolved
Hide resolved
here is the pr in ecocode-java-test-project |
This PR has been automatically marked as stale because it has no activity for 30 days. |
This PR has been automatically marked as stale because it has no activity for 30 days. |
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
created in mostly during the ecocode challenge 2024, this rule aims to avoid doing sql queries and not using selected columns. rule specification here