Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csk 에 memoize 적용 #94

Closed
wants to merge 2 commits into from
Closed

csk 에 memoize 적용 #94

wants to merge 2 commits into from

Conversation

neverlish
Copy link

@neverlish neverlish commented Jan 19, 2023 •
edited
Loading

@neverlish
Copy link
Author

#90 위에 이 브랜치를 올리고, farmmy-backend 에 적용해서 테스트해볼까
하는 생각이 있습니다

namenu
namenu approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@namenu namenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실 이거 case converter 는 gosura 의 영역이 아니거나, 변환 함수를 넘길 수 있게 설계되어야 하는데...
일단 성능 체크를 위해 이 방법이 최선이겠어요

@neverlish neverlish mentioned this pull request Jan 19, 2023
Closed
@neverlish neverlish marked this pull request as draft January 20, 2023 01:04
@neverlish neverlish closed this Jan 20, 2023
@neverlish neverlish deleted the csk-memoize branch January 20, 2023 01:04
@neverlish
Copy link
Author

이번 PR 은 불필요하고, 테스트를 위해서는 #96 를 사용하면 되어서
이 PR은 닫습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namenu namenu namenu approved these changes

@jungwookim jungwookim Awaiting requested review from jungwookim

@devgrapher devgrapher Awaiting requested review from devgrapher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neverlish @namenu