-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: unit tests #1756
base: main
Are you sure you want to change the base?
Fix: unit tests #1756
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
misc/ipc_openvas_tests.c
Outdated
is_equal_to_string ("TLS certificate")); | ||
|
||
ipc_data_destroy (&data_r); | ||
for (int j = 0; json_fake[j] != '\0'; j++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: why j and not i? this seems to be the outer loop.
misc/ipc_openvas_tests.c
Outdated
|
||
// malformed json string | ||
// json string with more than one objects | ||
json_fake = | ||
g_strdup ("{\"type\":1,\"source\":\"TLS " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why didn't you use stack but put that into the heap?
I would suggest to change the first commit message to not contain a conventional commit, as this has no impact for the user. |
What:
Fix unit tests
Closes #1724
Jira: SC-1170
Why:
It is broken, but for some reason cgreen with older libjson-glib doesn't failed.
How:
Checklist: