Change: Drop typing_extensions dependency. #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Filespyproject.toml
|
Conventional Commits Report
🚀 Conventional commits found. |
auto-merge was automatically disabled
July 12, 2024 10:20
Pull request was converted to draft
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 65 65
Lines 4544 4544
Branches 832 832
=======================================
Hits 4434 4434
Misses 74 74
Partials 36 36 ☔ View full report in Codecov by Sentry. |
timopollmeier
approved these changes
Jul 17, 2024
Drop the use of the Self component from typing_extensions and use the typing library instead
timopollmeier
force-pushed
the
drop-typing-extensions-dependency
branch
from
c5a42f3
to
cd29fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Drop typing_extensions dependency.
Why
typing_extensions was needed for using the Self component (which was introduced in version 4.0.0) however the versions shipped with Debian are older.
typing_extensions is dropped and the typing library is used instead.
References
GEA-638