Feature/gsye 630 #1683
Merged
Feature/gsye 630 #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 67.84% 67.98% +0.14%
==========================================
Files 140 140
Lines 13209 13259 +50
Branches 1988 2003 +15
==========================================
+ Hits 8961 9014 +53
+ Misses 3762 3757 -5
- Partials 486 488 +2 |
src/gsy_e/gsy_e_core/live_events.py
Outdated
| @@ -43,8 +46,31 @@ def __repr__(self): | |||
| f"params({self.area_representation}))>" | |||
|
|
|||
|
|
|||
| class CreateAreaEventCoefficient(CreateAreaEvent): | |||
| """Event that creates a new area on the area representation tree.""" | |||
There was a problem hiding this comment.
NIT:
"Event that creates a new area on the area representation tree for SCM simulations"
tests/test_gsy_core/live_events/test_coefficient_live_events.py
Outdated
Show resolved
Hide resolved
tests/test_global_objects.py
Outdated
Comment on lines
35
to
37
| class TestGlobalObjects(unittest.TestCase): | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
NIT: Would be a good opportunity to remove the unittest dependency here
There was a problem hiding this comment.
Perfect, let me change that. Thanks!
hannesdiedrich
previously approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master