Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-631: Fix _calc_energy_to_buy_minimum in HP energy parameters #1684

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

hannesdiedrich
Copy link
Member

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=bug/GSYE-631
GSY_FRAMEWORK_BRANCH=master

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1684 (3661752) into master (ece9724) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1684   +/-   ##
=======================================
  Coverage   67.87%   67.88%           
=======================================
  Files         140      140           
  Lines       13192    13192           
  Branches     1987     1987           
=======================================
+ Hits         8954     8955    +1     
+ Misses       3752     3749    -3     
- Partials      486      488    +2     

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannesdiedrich hannesdiedrich merged commit b4f0e67 into master Sep 15, 2023
2 of 3 checks passed
@hannesdiedrich hannesdiedrich deleted the bug/GSYE-631 branch September 15, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants