-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added images to the main blockchain page and to the blockchain system… #1697
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
eee2c1f
Added images to the main blockchain page and to the blockchain system…
spyrostz 8164505
Harmonized image / caption definition in order to be consistent with …
spyrostz 774d9e5
Fixed numbering on the image captions.
spyrostz 491b834
Merge branch 'master' into bc-wiki-images
spyrostz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I took the liberty in my last PR to homogenize the images and used the following html snippet (under: "Add figure caption" here: https://github.com/gridsingularity/gsy-e/tree/master/wiki#images
This will connect the image with its caption
Could you also please follow this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I also prepended the section number in the figure number:
For the BC section this would result in:
Figure 6.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darn, it makes the documentation files a bit ugly, too bad that mkdocs does not natively support this. Will fix, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also hate that this is not supported be default, but also open to alternatives.
I remember quite some digging though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I do not like this at all. I will follow this for consistency's purpose however this means that if we insert one new section after current section #1, we will have to change the figure numbers of all the sections apart from 1. Regardless, let me do it and if we stumble upon it we will see how to deal with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about this, but thought that this will be kind of easy with a search & replace. Of course, this search&replace will have to be performed n times and if the number of sections is increased a lot, this is not so quick any more.
If we do not follow this "sectionisation", we will have to change all figure names if we want to insert a figure in section 1 by hand or we will have a Figure 82 below Figure 1 (not that I care that much about that, just wanted to outline my reasoning).