Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-826: Adapt launch_simulation_from_rq_job for new non-p2p market … #1819

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

hannesdiedrich
Copy link
Member

…type

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=feature/GSYE-826

@hannesdiedrich hannesdiedrich requested a review from a team December 13, 2024 13:44
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.50%. Comparing base (1b5c641) to head (b1dab79).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
- Coverage   69.55%   69.50%   -0.05%     
==========================================
  Files         148      148              
  Lines       14181    14181              
  Branches     2656     2656              
==========================================
- Hits         9863     9856       -7     
- Misses       3793     3800       +7     
  Partials      525      525              

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannesdiedrich hannesdiedrich merged commit 8e4024a into master Dec 16, 2024
2 of 4 checks passed
@hannesdiedrich hannesdiedrich deleted the feature/GSYE-826 branch December 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants