Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some theming-related issues #914

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Fix some theming-related issues #914

merged 1 commit into from
Jan 13, 2024

Conversation

ialokim
Copy link
Collaborator

@ialokim ialokim commented Jan 11, 2024

@cla-bot cla-bot bot added the cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. label Jan 11, 2024
Copy link
Collaborator

@Altonss Altonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine for me (Android 13). It would be good to check also on other versions (older also if possible).
Ping @MatsG23, this should fix your issue :)

@MatsG23
Copy link

MatsG23 commented Jan 12, 2024

I wanted to test the changes to see if my issue is resolved but the PR does not contain a build artifact and I could not install my self-built APK (probably because it is unsigned). Anyways, I am also not using an older version of Android as well.

@ialokim
Copy link
Collaborator Author

ialokim commented Jan 13, 2024

Just tested locally on a Android 5 (API 21) powered emulator. Fixed a bug where dark mode would not be recognized for Android <10 when battery saver mode is enabled. Everything else worked as expected.

@ialokim ialokim merged commit af5841b into master Jan 13, 2024
4 checks passed
@ialokim ialokim deleted the theme-fixes branch January 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default theme setting is ignored Background color of changelog is dark when in light mode.
3 participants