Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display date when trip is not the same day #946

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Altonss
Copy link
Collaborator

@Altonss Altonss commented May 13, 2024

This fixes #185

@Altonss Altonss requested review from grote and ialokim May 13, 2024 13:57
@cla-bot cla-bot bot added the cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. label May 13, 2024
@Altonss
Copy link
Collaborator Author

Altonss commented Nov 1, 2024

Unit tests are now time dependent, which seems to be a mess to tackle. I don't know what's the simplest way to fix this...

@Altonss
Copy link
Collaborator Author

Altonss commented Nov 4, 2024

I'll will merge this as it is right now, as it more important to fix #185 then to try the (complex) formatRelativeTimeTest() run. Works well on Android 5 and 13 👍
Feel free to comment/open an issue if there is anything about this change you wish to discuss :)

@Altonss Altonss merged commit b8e78c2 into grote:master Nov 4, 2024
4 checks passed
@Altonss Altonss deleted the displayDate branch November 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate when trips are for the next day
1 participant