Merge pull request #144 from growthbook/fallback-issue-fix2

New test case
growthbook · Oct 10, 2024 · d787829 · d787829
2 parents 782b291 + 2142820
commit d787829
Show file tree

Hide file tree

Showing 2 changed files with 68 additions and 2 deletions.
diff --git a/GrowthBook/src/commonMain/kotlin/com/sdk/growthbook/utils/GBUtils.kt b/GrowthBook/src/commonMain/kotlin/com/sdk/growthbook/utils/GBUtils.kt
@@ -424,8 +424,8 @@ internal class GBUtils {
 
             val (fallbackAttribute, fallbackValue) = getHashAttribute(
                 context = context,
-                attr = null,
-                fallback = expFallBackAttribute,
+                attr = expFallBackAttribute,
+                fallback = null,
                 attributeOverrides = attributeOverrides
             )
 

diff --git a/GrowthBook/src/commonTest/kotlin/com/sdk/growthbook/tests/cases.json b/GrowthBook/src/commonTest/kotlin/com/sdk/growthbook/tests/cases.json
@@ -5810,6 +5810,72 @@
         }
       }
     ],
+    [
+      "upgrades a sticky bucket doc from a fallbackAttribute to a hashAttribute",
+      {
+        "attributes": {
+          "id": "i123",
+          "anonymousId": "ses123",
+          "foo": "bar",
+          "country": "USA"
+        },
+        "features": {
+          "exp1": {
+            "defaultValue": "control",
+            "rules": [
+              {
+                "key": "feature-exp",
+                "seed": "feature-exp",
+                "hashAttribute": "id",
+                "fallbackAttribute": "anonymousId",
+                "hashVersion": 2,
+                "bucketVersion": 0,
+                "condition": { "country": "USA" },
+                "variations": ["control", "red", "blue"],
+                "meta": [{ "key": "0" }, { "key": "1" }, { "key": "2" }],
+                "coverage": 1,
+                "weights": [0.3334, 0.3333, 0.3333],
+                "phase": "0"
+              }
+            ]
+          }
+        }
+      },
+      [
+        {
+          "attributeName": "anonymousId",
+          "attributeValue": "ses123",
+          "assignments": {
+            "feature-exp__0": "1"
+          }
+        }
+      ],
+      "exp1",
+      {
+        "bucket": 0.9943,
+        "featureId": "exp1",
+        "hashAttribute": "id",
+        "hashUsed": true,
+        "hashValue": "i123",
+        "inExperiment": true,
+        "key": "1",
+        "stickyBucketUsed": true,
+        "value": "red",
+        "variationId": 1
+      },
+      {
+        "anonymousId||ses123": {
+          "assignments": { "feature-exp__0": "1" },
+          "attributeName": "anonymousId",
+          "attributeValue": "ses123"
+        },
+        "id||i123": {
+          "assignments": { "feature-exp__0": "1" },
+          "attributeName": "id",
+          "attributeValue": "i123"
+        }
+      }
+    ],
     [
       "favors a sticky bucket doc based on hashAttribute over fallbackAttribute",
       {