Add support for compiling to Kotlin/JS targets #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bohdan-Kim
reviewed
Oct 31, 2024
|
|
Bohdan-Kim
reviewed
Nov 5, 2024
|
I've added changes to support 1.8 compilation but I would like to also add that this doesn't really seem valuable. JRE 8 is ancient and support for using it anywhere internet facing is rapidly dwindling in favor of 11,17, and 21. |
Bohdan-Kim
reviewed
Nov 6, 2024
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest package="com.sdk.growthbook" | |||
There was a problem hiding this comment.
Could you please clarify why package was removed?
There was a problem hiding this comment.
This was done to resolve the following warning during build time:
> Task :NetworkDispatcherKtor:processDebugManifest
package="com.sdk.growthbook" found in source AndroidManifest.xml: /home/farmerbb/growthbook-kotlin/NetworkDispatcherKtor/src/androidMain/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.
Having the package attribute in the manifest results in an error when using Android Gradle Plugin 8.0.0 or higher.
However, it doesn't matter as much now that we've downgraded back to 7.4.2 for this PR.
Bohdan-Kim
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for compiling to Kotlin/JS targets.
In order to get compilation working, the following dependencies have been upgraded:
Android Gradle Plugin: 7.4.2 -> 8.7.1JDK: 11 -> 17NOTE: This is a requirement of the Android Gradle Plugin version bump, and does not affect the ability for apps to implement the SDK on earlier Java versions. The Kotlin JVM target is still set to 1.8.