Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: Improved sequencing documentation for server-side stats events and added tests. #7885

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
44abfd0
Improved sequencing Documentation for the stats events and added test…
RyanBlaney Dec 1, 2024
10f6726
Fix formatting issues according to Google style guide
RyanBlaney Dec 2, 2024
92ec341
Removed unnecessary time stamps from event tracing
RyanBlaney Dec 2, 2024
71adf5e
Cleared up difference between client side and server side stat events…
RyanBlaney Dec 3, 2024
8622eab
Fixed documentation style and whitespace between comments. Put the or…
RyanBlaney Dec 11, 2024
f291e58
Fixed return wrapping. Added note about StartServer using deprecated …
RyanBlaney Dec 11, 2024
dcb64c1
Fixed documentation in stats.go with unnecessary line breaks.
RyanBlaney Dec 17, 2024
c157b93
Removed unnecessary comments and fixed format wrapping mistakes.
RyanBlaney Dec 17, 2024
480ce6b
Fixed remaining wrapping mistakes
RyanBlaney Dec 18, 2024
8b90cae
Fixed a few style issues
RyanBlaney Dec 18, 2024
443d960
Fixed the last of the style issues
RyanBlaney Dec 18, 2024
436bc06
Fixed vet errors.
RyanBlaney Dec 21, 2024
19b4974
Ran gofmt -s -w
RyanBlaney Dec 21, 2024
53b7249
Put wanted test sequences in their respective test functions. Additio…
RyanBlaney Dec 28, 2024
6a8c733
minor style adjustment
RyanBlaney Dec 28, 2024
4a18e7e
Got rid of vet error
RyanBlaney Dec 28, 2024
fb39711
Ran gofmt and goimports
RyanBlaney Dec 28, 2024
e37254c
Removed 'expected' and clarified comments.
RyanBlaney Jan 9, 2025
0fdf514
ran gofmt
RyanBlaney Jan 12, 2025
ebecb99
used copy instead of a loop
RyanBlaney Jan 12, 2025
ebd2156
Added clarity to and . Minor style adjustments.
RyanBlaney Jan 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion stats/stats.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ type RPCStats interface {
}

// Begin contains stats when an RPC attempt begins.
// This event is called AFTER the InHeader event, as headers must
purnesh42H marked this conversation as resolved.
Show resolved Hide resolved
// be processed before the RPC lifecycle begins.
//
// FailFast is only valid if this Begin is from client side.
type Begin struct {
// Client is true if this Begin is from client side.
Expand Down Expand Up @@ -98,7 +101,10 @@ func (s *InPayload) IsClient() bool { return s.Client }

func (s *InPayload) isRPCStats() {}

// InHeader contains stats when a header is received.
// InHeader contain stats when the header is received.
//
// First event in the server side event sequence.
// Follows last OutPayload for server side events.
purnesh42H marked this conversation as resolved.
Show resolved Hide resolved
type InHeader struct {
purnesh42H marked this conversation as resolved.
Show resolved Hide resolved
// Client is true if this InHeader is from client side.
Client bool
Expand All @@ -123,6 +129,7 @@ func (s *InHeader) IsClient() bool { return s.Client }

func (s *InHeader) isRPCStats() {}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix new line

Copy link
Author

@RyanBlaney RyanBlaney Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does nix mean in this context? I'm assuming you mean delete. I don't see an extra space between functions on my end so I'm confused what you're asking here.

// InTrailer contains stats when a trailer is received.
type InTrailer struct {
// Client is true if this InTrailer is from client side.
Expand Down
Loading
Loading