Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment targets to the package manifest #7

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Oct 4, 2024

Motivation:

Core components of grpc-swift v2 require API from the latest SDKs. This causes a proliferation of availability annotations through our API. Rather than doing this we can set the minimum platforms in the package manifest.

Modifications:

  • Remove availability annotations
  • Set platforms in the package manifest

Result:

  • Less boilerplate
  • Users must set platforms in their package manifest

Motivation:

Core components of grpc-swift v2 require API from the latest SDKs. This
causes a proliferation of availability annotations through our API.
Rather than doing this we can set the minimum platforms in the package
manifest.

Modifications:

- Remove availability annotations
- Set platforms in the package manifest

Result:

- Less boilerplate
- Users must set platforms in their package manifest
@glbrntt glbrntt requested a review from gjcairo October 4, 2024 09:34
@glbrntt glbrntt added the ⚠️ semver/major Breaks existing public API. label Oct 4, 2024
@glbrntt glbrntt merged commit 0e95676 into grpc:main Oct 4, 2024
3 of 4 checks passed
@glbrntt glbrntt deleted the platforms branch October 4, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants