Add support for TLS on H2 NIOTS server transport #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
ssl-niots-server-transport
branch
from
f0c2915
to
d264b0c
Compare
glbrntt
requested changes
Sep 2, 2024
Sources/GRPCHTTP2TransportNIOTransportServices/HTTP2ServerTransport+TransportServices.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOTransportServices/HTTP2ServerTransport+TransportServices.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportTests/HTTP2TransportNIOTransportServicesTests.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
ssl-niots-server-transport
branch
from
d264b0c
to
4560e6a
Compare
gjcairo
force-pushed
the
ssl-niots-server-transport
branch
from
2e7619b
to
46fa441
Compare
gjcairo
force-pushed
the
ssl-niots-server-transport
branch
from
60f2a8f
to
d87fa00
Compare
glbrntt
reviewed
Sep 9, 2024
glbrntt
reviewed
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have a NIOTS server transport implementation in gRPC v2, but it doesn't support TLS.
Modifications
This PR adds support for TLS in the NIOTS-backed HTTP/2 implementation of the server transport for gRPC v2.
It also adds support for ALPN, to validate that the negotiated protocol, if required, is HTTP2 or
grpc-exp. If it's not, an error will be fired/the channel will be closed, since we don't support H1.Result
We now support TLS/ALPN when using the NIOTS server transport in gRPC V2.