Simplify syntax in example code #184
Conversation
|
To be fair, there isn't an explicit mention of this in the style guide. But thanks for all the links, including to SO. I'd rather not update old blog entries. For the rest, I'd rather that the site reflect the actual sources that they are originating from. So this would mean making changes to each of the corresponding repos, and then only making the change here once the original sources have been updated. I'd suggest that we take it one language at a time. Let me first try with the new Kotlin example, since I've done some cleanup in that |
|
FYI, cleanup done for gRPC-Kotlin examples - grpc/grpc-kotlin#62. |
|
Makes sense, I'll revert the changes to the blog post. As for the source repositories, point taken, and thanks for the Kotlin example. Are you planning to make the remaining changes yourself, or should I go ahead and submit PRs? |
Use a semicolon instead of an empty options list. This is consistent with the style guide and examples and in the protobuf documentation: - https://developers.google.com/protocol-buffers/docs/style#services - https://developers.google.com/protocol-buffers/docs/proto3#services - https://developers.google.com/protocol-buffers/docs/reference/proto3-spec#service_definition
waldyrious
force-pushed
the
empty-options
branch
from
a6a71f7
to
f9e5bbb
Compare
I'd like to propose simplifications to the |
|
Hi @waldyrious: it'll take a while before this is addressed (in part because we need to resolve issues like grpc/grpc-proto#81 first). Can you create an issue with the opening PR comment, and then close this PR? If you'd rather that I do it, let me know. |
|
Thanks for the update. I understand that coordinating changes across several repos is not straightforward.
I'd be more comfortable with you doing that, yeah — your context is more complete than mine. |
|
Closing. Will track progress via #282. |
Use a semicolon instead of an empty options list.
This is consistent with the style guide and examples and in the protobuf documentation: