Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjC] remove CLANG_CXX_LANGUAGE_STANDARD from podspecs #38031

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HannahShiSFB
Copy link
Collaborator

@HannahShiSFB HannahShiSFB commented Oct 30, 2024

This conflicts with defaults and cause build errors like firebase/firebase-ios-sdk#13989

@HannahShiSFB HannahShiSFB added release notes: no Indicates if PR should not be in release notes kokoro:run labels Oct 30, 2024
@sampajano
Copy link
Contributor

Thanks Hannah!! 😃

@paulb777 FYI :)

Copy link
Contributor

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this quickly, Hannah!!

@paulb777
Copy link
Contributor

Thanks, but this is a different change than I expected. I don't think this will with Firestore which expects gnu++14. Also, shouldn't gRPC compile the same way for both CocoaPods 1.15 and CocoaPods 1.16.

I expected the fix to be to add the gnu++14 setting to abseil's podspec.

@HannahShiSFB
Copy link
Collaborator Author

HannahShiSFB commented Oct 31, 2024

I'm afraid add the gnu++14 setting to abseil's podspec would cause more issues, as it can break other projects that's not setting the C++ standard which is more common and Apple's recommendation.

CocoaPods 1.15 build doesn't fail linking absl with this PR.

@paulb777
Copy link
Contributor

The xcodeproj gem of CocoaPods always sets CLANG_CXX_LANGUAGE_STANDARD CocoaPods/Xcodeproj@3157b7c#diff-ff9a4d09c635f0b936a889cc315e58fb2d38bf772b1712ea795498def364621aR424.

By not overriding it, users will build differently depending upon their CocoaPods gem versions.

@paulb777
Copy link
Contributor

Looks like the xcodeproj gem did another release 1.27.0 to revert the problematic Settings changes. https://github.com/CocoaPods/Xcodeproj/pull/992/files - so this change may not be necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants