-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObjC] remove CLANG_CXX_LANGUAGE_STANDARD from podspecs #38031
base: master
Are you sure you want to change the base?
Conversation
a1ac610
to
eecd48a
Compare
Thanks Hannah!! 😃 @paulb777 FYI :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this quickly, Hannah!!
Thanks, but this is a different change than I expected. I don't think this will with Firestore which expects gnu++14. Also, shouldn't gRPC compile the same way for both CocoaPods 1.15 and CocoaPods 1.16. I expected the fix to be to add the |
I'm afraid add the gnu++14 setting to abseil's podspec would cause more issues, as it can break other projects that's not setting the C++ standard which is more common and Apple's recommendation. CocoaPods 1.15 build doesn't fail linking absl with this PR. |
The By not overriding it, users will build differently depending upon their CocoaPods gem versions. |
Looks like the xcodeproj gem did another release 1.27.0 to revert the problematic Settings changes. https://github.com/CocoaPods/Xcodeproj/pull/992/files - so this change may not be necessary |
This conflicts with defaults and cause build errors like firebase/firebase-ios-sdk#13989