Skip to content

Commit

Permalink
Merge branch 'qmk:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
gskygithub authored Mar 27, 2024
2 parents 443f0ae + 1d58530 commit 5471b20
Show file tree
Hide file tree
Showing 96 changed files with 2,842 additions and 69 deletions.
10 changes: 8 additions & 2 deletions builddefs/converters.mk
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ ifneq ($(findstring yes, $(CTPC)$(CONVERT_TO_PROTON_C)),)
$(call CATASTROPHIC_ERROR,The `CONVERT_TO_PROTON_C` and `CTPC` options are now deprecated. `CONVERT_TO=proton_c` should be used instead.)
endif

# TODO: opt in rather than assume everything uses a pro micro
PIN_COMPATIBLE ?= promicro
ifneq (,$(filter $(MCU),atmega32u4))
# TODO: opt in rather than assume everything uses a pro micro
PIN_COMPATIBLE ?= promicro
endif

# Remove whitespace from any rule.mk provided vars
# - env cannot be overwritten but cannot have whitespace anyway
Expand All @@ -16,6 +18,10 @@ ifneq ($(CONVERT_TO),)
# stash so we can overwrite env provided vars if needed
ACTIVE_CONVERTER=$(CONVERT_TO)

ifeq ($(PIN_COMPATIBLE),)
$(call CATASTROPHIC_ERROR,Converting to '$(CONVERT_TO)' not possible!)
endif

# glob to search each platfrorm and/or check for valid converter
CONVERTER := $(wildcard $(PLATFORM_PATH)/*/converters/$(PIN_COMPATIBLE)_to_$(CONVERT_TO)/)
ifeq ($(CONVERTER),)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -335,5 +335,9 @@
"key": "ES_CIRC",
"label": "^",
}
"ALGR(KC_NUHS)": {
"key": "ES_GRV",
"label": "`",
}
}
}
16 changes: 9 additions & 7 deletions docs/pr_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ If there are any inconsistencies with these recommendations, you're best off [cr
- PR should be submitted using a non-`master` branch on the source repository
- this does not mean you target a different branch for your PR, rather that you're not working out of your own master branch
- if submitter _does_ use their own `master` branch, they'll be given a link to the ["how to git"](newbs_git_using_your_master_branch.md) page after merging -- (end of this document will contain the contents of the message)
- Note, frequently merging upstream with your branch is not needed and is discouraged. Valid reason for updating your branch may be resolving merge conflicts and pulling in new changes relevant to your PR.
- PRs should contain the smallest amount of modifications required for a single change to the codebase
- multiple keyboards at the same time is not acceptable
- **the smaller the PR, the higher likelihood of a quicker review, higher likelihood of quicker merge, and less chance of conflicts**
Expand Down Expand Up @@ -43,10 +44,10 @@ If there are any inconsistencies with these recommendations, you're best off [cr

- PRs for vendor specific keymaps will be permitted. The naming convention for these should be `default_${vendor}`, `via_${vendor}` i.e. `via_clueboard`.
- vendor specific keymaps do not necessarily need to be "vanilla" and can be more richly featured than `default` or `via` stock keymaps.
- #include QMK_KEYBOARD_H preferred to including specific board files
- `#include QMK_KEYBOARD_H` preferred to including specific board files
- prefer layer enums to #defines
- custom keycode enums must have first entry = SAFE_RANGE
- some care with spacing (e.g., alignment on commas or first char of keycodes) makes for a much nicer-looking keymap
- custom keycode enums must have first entry = `QK_USER`
- some care with spacing (e.g., alignment on commas or first char of keycodes) makes for a much nicer-looking keymap. Spaces are preferred to tabs

## Keyboard PRs

Expand Down Expand Up @@ -81,6 +82,8 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
- Encoder Configuration
- Bootmagic Configuration
- LED Indicator Configuration
- RGB Light Configuration
- RGB Matrix Configuration
- Run `qmk format-json` on this file before submitting your PR. Be sure to append the `-i` flag to directly modify the file, or paste the outputted code into the file.
- `readme.md`
- must follow the [template](https://github.com/qmk/qmk_firmware/blob/master/data/templates/keyboard/readme.md)
Expand All @@ -90,8 +93,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
- a picture about the keyboard and preferably about the PCB, too
- images are not to be placed in the `qmk_firmware` repository
- images should be uploaded to an external image hosting service, such as [imgur](https://imgur.com/).
- if imgur is used, images should be resized appropriately: append "h" to the image url i.e. [https://i.imgur.com/vqgE7Ok.jpg](https://i.imgur.com/vqgE7Ok.jpg) becomes [https://i.imgur.com/vqgE7Ok**h**.jpg](https://i.imgur.com/vqgE7Okh.jpg)
- image links should link directly to the image, not a "preview" -- i.e. [https://imgur.com/vqgE7Ok](https://imgur.com/vqgE7Ok) should be [https://i.imgur.com/vqgE7Okh.jpg](https://i.imgur.com/vqgE7Okh.jpg) when using imgur
- image links should link directly to the image, not a "preview" -- i.e. [https://imgur.com/vqgE7Ok](https://imgur.com/vqgE7Ok) should be [https://i.imgur.com/vqgE7Ok.jpg](https://i.imgur.com/vqgE7Ok.jpg) when using imgur
- `rules.mk`
- removed `MIDI_ENABLE`, `FAUXCLICKY_ENABLE` and `HD44780_ENABLE`
- modified `# Enable Bluetooth with the Adafruit EZ-Key HID` -> `# Enable Bluetooth`
Expand Down Expand Up @@ -204,7 +206,7 @@ Additionally, PR reviews are something that is done in our free time. We are not
## Example GPLv2 Header

```
/* Copyright 2021 Your Name (@yourgithub)
/* Copyright 2024 Your Name (@yourgithub)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
Expand All @@ -224,6 +226,6 @@ Additionally, PR reviews are something that is done in our free time. We are not
Or, optionally, using [SPDX identifier](https://spdx.org/licenses/) instead:

```
// Copyright 2021 Your Name (@yourgithub)
// Copyright 2024 Your Name (@yourgithub)
// SPDX-License-Identifier: GPL-2.0-or-later
```
7 changes: 3 additions & 4 deletions keyboards/bastardkb/charybdis/3x5/v2/stemcell/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,14 @@

/* SPI config for pmw3360 sensor. */
#define SPI_DRIVER SPID1
#define SPI_SCK_PIN B1
#define SPI_SCK_PIN A5
#define SPI_SCK_PAL_MODE 5
#define SPI_MOSI_PIN B2
#define SPI_MOSI_PIN A7
#define SPI_MOSI_PAL_MODE 5
#define SPI_MISO_PIN B3
#define SPI_MISO_PIN A6
#define SPI_MISO_PAL_MODE 5

/* PMW3360 settings. */
#define A1 PAL_LINE(GPIOA, 1)
#define POINTING_DEVICE_CS_PIN A1
#define PMW3360_CS_MODE 3
#define PMW3360_CS_DIVISOR 64
11 changes: 5 additions & 6 deletions keyboards/bastardkb/charybdis/3x5/v2/stemcell/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@
"driver": "ws2812"
},
"ws2812": {
"pin": "D3",
"pin": "A2",
"driver": "pwm"
},
"build": {
"debounce_type": "asym_eager_defer_pk"
},
"matrix_pins": {
"cols": ["F5", "B6", "D7", "E6", "B4"],
"rows": ["F7", "C6", "D4", "B5"]
"cols": ["B2", "A4", "B4", "B5", "B8"],
"rows": ["B0", "B3", "A15", "B9"]
},
"diode_direction": "ROW2COL",
"split": {
"soft_serial_pin": "D2"
"soft_serial_pin": "A3"
},
"processor": "STM32F411",
"bootloader": "stm32-dfu"
"development_board": "stemcell"
}
2 changes: 0 additions & 2 deletions keyboards/bastardkb/charybdis/3x5/v2/stemcell/rules.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CONVERT_TO = stemcell

# Build Options
# change yes to no to disable
#
Expand Down
7 changes: 3 additions & 4 deletions keyboards/bastardkb/charybdis/3x6/v2/stemcell/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,14 @@

/* SPI config for pmw3360 sensor. */
#define SPI_DRIVER SPID1
#define SPI_SCK_PIN B1
#define SPI_SCK_PIN A5
#define SPI_SCK_PAL_MODE 5
#define SPI_MOSI_PIN B2
#define SPI_MOSI_PIN A7
#define SPI_MOSI_PAL_MODE 5
#define SPI_MISO_PIN B3
#define SPI_MISO_PIN A6
#define SPI_MISO_PAL_MODE 5

/* PMW3360 settings. */
#define A1 PAL_LINE(GPIOA, 1)
#define POINTING_DEVICE_CS_PIN A1
#define PMW3360_CS_MODE 3
#define PMW3360_CS_DIVISOR 64
11 changes: 5 additions & 6 deletions keyboards/bastardkb/charybdis/3x6/v2/stemcell/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@
"driver": "ws2812"
},
"ws2812": {
"pin": "D3",
"pin": "A2",
"driver": "pwm"
},
"build": {
"debounce_type": "asym_eager_defer_pk"
},
"matrix_pins": {
"cols": ["F6", "F5", "B6", "D7", "E6", "B4"],
"rows": ["F7", "C6", "D4", "B5"]
"cols": ["B1", "B2", "A4", "B4", "B5", "B8"],
"rows": ["B0", "B3", "A15", "B9"]
},
"diode_direction": "ROW2COL",
"split": {
"soft_serial_pin": "D2"
"soft_serial_pin": "A3"
},
"processor": "STM32F411",
"bootloader": "stm32-dfu"
"development_board": "stemcell"
}
2 changes: 0 additions & 2 deletions keyboards/bastardkb/charybdis/3x6/v2/stemcell/rules.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CONVERT_TO = stemcell

# Build Options
# change yes to no to disable
#
Expand Down
7 changes: 3 additions & 4 deletions keyboards/bastardkb/charybdis/4x6/v2/stemcell/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,14 @@

/* SPI config for pmw3360 sensor. */
#define SPI_DRIVER SPID1
#define SPI_SCK_PIN B1
#define SPI_SCK_PIN A5
#define SPI_SCK_PAL_MODE 5
#define SPI_MOSI_PIN B2
#define SPI_MOSI_PIN A7
#define SPI_MOSI_PAL_MODE 5
#define SPI_MISO_PIN B3
#define SPI_MISO_PIN A6
#define SPI_MISO_PAL_MODE 5

/* PMW3360 settings. */
#define A1 PAL_LINE(GPIOA, 1)
#define POINTING_DEVICE_CS_PIN A1
#define PMW3360_CS_MODE 3
#define PMW3360_CS_DIVISOR 64
11 changes: 5 additions & 6 deletions keyboards/bastardkb/charybdis/4x6/v2/stemcell/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@
"driver": "ws2812"
},
"ws2812": {
"pin": "D3",
"pin": "A2",
"driver": "pwm"
},
"build": {
"debounce_type": "asym_eager_defer_pk"
},
"matrix_pins": {
"cols": ["F6", "F5", "B6", "D7", "E6", "B4"],
"rows": ["F4", "F7", "C6", "D4", "B5"]
"cols": ["B1", "B2", "A4", "B4", "B5", "B8"],
"rows": ["B10", "B0", "B3", "A15", "B9"]
},
"diode_direction": "ROW2COL",
"split": {
"soft_serial_pin": "D2"
"soft_serial_pin": "A3"
},
"processor": "STM32F411",
"bootloader": "stm32-dfu"
"development_board": "stemcell"
}
2 changes: 0 additions & 2 deletions keyboards/bastardkb/charybdis/4x6/v2/stemcell/rules.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CONVERT_TO = stemcell

# Build Options
# change yes to no to disable
#
Expand Down
11 changes: 5 additions & 6 deletions keyboards/bastardkb/scylla/v2/stemcell/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@
"driver": "ws2812"
},
"ws2812": {
"pin": "D3",
"pin": "A2",
"driver": "pwm"
},
"build": {
"debounce_type": "asym_eager_defer_pk"
},
"matrix_pins": {
"cols": ["F6", "F5", "B6", "D7", "E6", "B4"],
"rows": ["F4", "F7", "C6", "D4", "B5"]
"cols": ["B1", "B2", "A4", "B4", "B5", "B8"],
"rows": ["B10", "B0", "B3", "A15", "B9"]
},
"diode_direction": "ROW2COL",
"split": {
"soft_serial_pin": "D2"
"soft_serial_pin": "A3"
},
"processor": "STM32F411",
"bootloader": "stm32-dfu"
"development_board": "stemcell"
}
2 changes: 0 additions & 2 deletions keyboards/bastardkb/scylla/v2/stemcell/rules.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CONVERT_TO = stemcell

# Build Options
# change yes to no to disable
#
Expand Down
11 changes: 5 additions & 6 deletions keyboards/bastardkb/skeletyl/v2/stemcell/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@
"driver": "ws2812"
},
"ws2812": {
"pin": "D3",
"pin": "A2",
"driver": "pwm"
},
"build": {
"debounce_type": "asym_eager_defer_pk"
},
"matrix_pins": {
"cols": ["F5", "B6", "D7", "E6", "B4"],
"rows": ["F7", "C6", "D4", "B5"]
"cols": ["B2", "A4", "B4", "B5", "B8"],
"rows": ["B0", "B3", "A15", "B9"]
},
"diode_direction": "ROW2COL",
"split": {
"soft_serial_pin": "D2"
"soft_serial_pin": "A3"
},
"processor": "STM32F411",
"bootloader": "stm32-dfu"
"development_board": "stemcell"
}
2 changes: 0 additions & 2 deletions keyboards/bastardkb/skeletyl/v2/stemcell/rules.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CONVERT_TO = stemcell

# Build Options
# change yes to no to disable
#
Expand Down
11 changes: 5 additions & 6 deletions keyboards/bastardkb/tbkmini/v2/stemcell/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@
"driver": "ws2812"
},
"ws2812": {
"pin": "D3",
"pin": "A2",
"driver": "pwm"
},
"build": {
"debounce_type": "asym_eager_defer_pk"
},
"matrix_pins": {
"cols": ["F6", "F5", "B6", "D7", "E6", "B4"],
"rows": ["F7", "C6", "D4", "B5"]
"cols": ["B1", "B2", "A4", "B4", "B5", "B8"],
"rows": ["B0", "B3", "A15", "B9"]
},
"diode_direction": "ROW2COL",
"split": {
"soft_serial_pin": "D2"
"soft_serial_pin": "A3"
},
"processor": "STM32F411",
"bootloader": "stm32-dfu"
"development_board": "stemcell"
}
2 changes: 0 additions & 2 deletions keyboards/bastardkb/tbkmini/v2/stemcell/rules.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CONVERT_TO = stemcell

# Build Options
# change yes to no to disable
#
Expand Down
Loading

0 comments on commit 5471b20

Please sign in to comment.