Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misaligned checkmark background on tile with illustration #1227

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

tjosepo
Copy link
Member

@tjosepo tjosepo commented Aug 28, 2023

Issue: #1226

Summary

Fixes this icon:

image

What I did

Made the background of the checkmark icon an actual background, instead of a ::before pseudo-element. Move the checkmark inside the markup.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes

  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: 67c8bfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@orbit-ui/components Patch
@sharegate/orbit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tjosepo tjosepo requested a review from fraincs August 28, 2023 15:23
@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for sg-orbit ready!

Name Link
🔨 Latest commit 67c8bfa
🔍 Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/64ecbf0da723040008d91bff
😎 Deploy Preview https://deploy-preview-1227--sg-orbit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for sg-storybook ready!

Name Link
🔨 Latest commit 67c8bfa
🔍 Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/64ecbf0d0f80b400081c1dd5
😎 Deploy Preview https://deploy-preview-1227--sg-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fraincs fraincs merged commit 5368434 into master Aug 29, 2023
5 checks passed
@fraincs fraincs deleted the 1226-tile-checkmark-bug branch August 29, 2023 13:16
@patricklafrance
Copy link
Member

@fraincs @tjosepo was there any Chromatic tests validating this? There should have been visual test coverage making sure this kind of issue doesn't get merge in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants