gio: Work around GLib memory leak in g_dbus_connection_register_objec… #1600
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_with_closures() Assume that the invocation is passed as `transfer full` into the closure. This workaround is not going to break with future versions of GLib as fixing the bug was considered a breaking API change. See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4427
sdroege
added
the
needs-backport
sdroege
commented
Dec 10, 2024
Comment on lines
+229
to
+232
| let invocation = from_glib_full(glib::gobject_ffi::g_value_get_object( | ||
| args[6].as_ptr(), | ||
| ) | ||
| as *mut ffi::GDBusMethodInvocation); |
There was a problem hiding this comment.
Indentation is a bit strange, not sure why rustfmt does this
|
This breaks on the CI until GLib >= 2.82.4 or < 2.82.3 is available there. |
|
What a mess overall. I think the upstream function should be deprecated when there is a new one. |
|
That's the plan, probably: https://gitlab.gnome.org/GNOME/glib/-/issues/3560 |
sdroege
removed
the
needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t_with_closures()
Assume that the invocation is passed as
transfer fullinto the closure.This workaround is not going to break with future versions of GLib as fixing the bug was considered a breaking API change.
See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4427
CC @sophie-h