Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NoVuln node to ingestion when a package isn't affected #1274

Merged
merged 1 commit into from
Sep 28, 2023
Merged

add NoVuln node to ingestion when a package isn't affected #1274

merged 1 commit into from
Sep 28, 2023

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Sep 15, 2023 •
edited
Loading

Description of the PR

When ingesting VEX documents add NoVuln node if package is not affected

Fixes #1015

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@m-brophy m-brophy marked this pull request as draft September 15, 2023 15:51
@m-brophy m-brophy marked this pull request as ready for review September 25, 2023 13:45
@m-brophy
add NoVuln node to ingestion when a package isn't affected
a2723dd 
Signed-off-by: m-brophy <mbrophy@redhat.com>
mlieberman85
mlieberman85 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 17f51dd into guacsec:main Sep 28, 2023
9 checks passed
m-brophy added a commit to m-brophy/guac that referenced this pull request Oct 3, 2023
@m-brophy
add NoVuln node to ingestion when a package isn't affected (guacsec#1274
0396495 
)

Signed-off-by: m-brophy <mbrophy@redhat.com>
m-brophy added a commit to m-brophy/guac that referenced this pull request Oct 3, 2023
@m-brophy
add NoVuln node to ingestion when a package isn't affected (guacsec#1274
ddf6745 
)

Signed-off-by: m-brophy <mbrophy@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@mlieberman85 mlieberman85 mlieberman85 approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] When ingesting VEX documents add NoVuln node if package is not affected
3 participants
@m-brophy @mlieberman85 @jeffmendoza