fix: use unique sbom identifier for the uri field #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dejan Bosanac <dbosanac@redhat.com>
Signed-off-by: Dejan Bosanac <dbosanac@redhat.com>
|
e2e flakiness will be fixed once: #1367 merges. Will rerun the test for now |
pxp928
approved these changes
Oct 26, 2023
mihaimaruseac
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
HasSBOMhas aurifield that is currently set to the source information. Both SPDX and CyclonDX provide an unique uri that can be used to identify the SBOM document. By storing this information inHasSBOMwe are making it easier for folks to find "sbom-uri"->"top-level-package" relation.PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run