-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Id or inputspec #1708
Id or inputspec #1708
Conversation
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
b6047e5
to
5132ff1
Compare
Signed-off-by: pxp928 <parth.psu@gmail.com>
Working to fix up the failing tests |
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Ready for review |
@mrizzi FYI. Will need to make some updates on the ENT backend for this to be fully utilized. I will start some of the work today and we can sync up on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering, wouldn't it be better to make the input specs have an ID field and remove the !
s and move the requirement for the fields to be specified and not null in the root resolvers instead? It would at least remove remove all code changes for the verbs, I think.
We chatted about this and this would be the cleanest approach without removing which fields are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the schema change for noun ingests. Maybe ask the other maintainers.
Otherwise looks good with a small nit.
Approving in this case, though I still think that it adds one extra indirection in the query. The generated code now does double verification that the fields are not null, if we remove the |
I like the "union" approach as it is more clear to a reader of the schema what is and isn't required for an ingest, otherwise it would just be documentation or reading code to tell you that you can either supply ID or the rest of the fields in the object. |
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Description of the PR
Fixes issue #1261 and updates the
keyvalue
backend to use noun IDs else use the inputspec for Verb ingestion.Updates the assembler (bulk and single ingestion) to update the
IDorInputSpec
for each noun with its IDs before passing them to the verbs to be used.NOTE: The backends must ensure that the IDs are returned in the same order as the array of InputSpecs, added comments on noun ingestion to call this out.
This PR also deletes all the old unit tests for each backend, in favor of the centralized test suite.
Updates still need to be made on the
arango
andent
backend. Backend test suite needs to be updated to include ingested noun IDs in verb ingestion.PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run