Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use emoji to signal bot or human user #37

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Oct 23, 2024

What does this change?

Following on from #36, this change keeps the message structure more uniform. Rather than sometimes adding a prefix to the message, add a varying emoji to the last line. This should mean the messages are slightly easier to visually parse.

Images

image

Following on from #36, this change keeps the message structure more uniform.
This should mean the messages are slightly easier to visually parse.
src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@adamnfish adamnfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ love this!

I've a comment about whether we can be more accurate in our detection of bots / users.

src/main.rs Outdated Show resolved Hide resolved
@@ -36,6 +36,7 @@ pub struct GithubLabel {
pub struct GithubUser {
pub id: usize,
pub login: String,
pub r#type: String,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The r# prefix allows us to use the type keyword.

@akash1810 akash1810 merged commit 3422cbc into main Oct 23, 2024
8 checks passed
@akash1810 akash1810 deleted the aa/bot-refinement branch October 23, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants