Broaden @guardian/source peer dep requirements up to v6 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 98aa60d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I've tested with v6 and all seems fine (so I also assume that the intermediate versions work okay too). This ought to make upgrading incrementally on DCR more straightforward.
tjmw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Broaden the
@guardian/sourcepeer dep range from^1.0.1to>= 1.0.1 < 7. I've tested with v6 and the component rendering looks good (I've made an assumption that things are fine in the intermediate major versions too).As per our recommendations I've bumped the dev version to the latest acceptable.
How to test
Check that Chromatic is happy.
How can we measure success?
Have we considered potential risks?
Images
Accessibility