-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mobile Server Side config #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still in draft, just adding a few suggestions. This looks like a great start
live-app-versions | ||
myguardian-prefs-api | ||
mobile-content-events | ||
mobile-fastly-cache-purger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's add myguardian-support-services to this. The rest of this list looks great
|
||
- uses: guardian/actions-prnouncer@main | ||
with: | ||
google-webhook-url: ${{ secrets.EDITORIAL_TOOLS_GOOGLE_WEBHOOK_URL }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the webhook url we would need to make?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good spot, needs to update this
workflow_dispatch: | ||
schedule: | ||
# 9am Wednesdays | ||
- cron: "0 9 * * WED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ⭐
@@ -0,0 +1,65 @@ | |||
name: "[Editorial Tools] Google Chats PR Announcer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the name of this to Mobile
@alinaboghiu has kindly added a secret to this repo with the webhook url. Can someone confirm what the value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this change?
Add a workflow for a PR announcer for MSS projects.
We've configured to only announce PRs from scala steward and dependabot (enabled by this PR on actions-announcer) as a way to manage our health PRs.