Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mobile Server Side config #53

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Add Mobile Server Side config #53

merged 2 commits into from
Jun 7, 2024

Conversation

aracho1
Copy link
Contributor

@aracho1 aracho1 commented Jun 4, 2024

What does this change?

Add a workflow for a PR announcer for MSS projects.

We've configured to only announce PRs from scala steward and dependabot (enabled by this PR on actions-announcer) as a way to manage our health PRs.

@aracho1 aracho1 changed the title add mss config Add Mobile Server Side config Jun 4, 2024
Copy link
Contributor

@lindseydew lindseydew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in draft, just adding a few suggestions. This looks like a great start

live-app-versions
myguardian-prefs-api
mobile-content-events
mobile-fastly-cache-purger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's add myguardian-support-services to this. The rest of this list looks great


- uses: guardian/actions-prnouncer@main
with:
google-webhook-url: ${{ secrets.EDITORIAL_TOOLS_GOOGLE_WEBHOOK_URL }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the webhook url we would need to make?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good spot, needs to update this

workflow_dispatch:
schedule:
# 9am Wednesdays
- cron: "0 9 * * WED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ⭐

@@ -0,0 +1,65 @@
name: "[Editorial Tools] Google Chats PR Announcer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the name of this to Mobile

@aracho1 aracho1 marked this pull request as ready for review June 6, 2024 10:14
@aracho1
Copy link
Contributor Author

aracho1 commented Jun 7, 2024

@alinaboghiu has kindly added a secret to this repo with the webhook url. Can someone confirm what the value of threadKey in &threadKey={threadKey} should be?

Copy link
Member

@AshCorr AshCorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aracho1 aracho1 merged commit b8a18e1 into main Jun 7, 2024
@aracho1 aracho1 deleted the add-mss-repos branch June 7, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants