Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [FEATURE] Rewrite client with updated dependencies with gitauto model #24

Closed

Conversation

gitauto-ai[bot]
Copy link

@gitauto-ai gitauto-ai bot commented Jul 9, 2024

Original issue: #5

What is the feature

The feature involves rewriting the client with updated dependencies to ensure better performance, security, and maintainability. This includes using modern Rust HTTP client libraries and following best practices for API client development.

Why we need the feature

  1. Performance: Updated dependencies often come with performance improvements.
  2. Security: Newer versions of libraries fix known vulnerabilities.
  3. Maintainability: Using up-to-date libraries ensures that the codebase remains maintainable and easier to work with for future developers.
  4. Best Practices: Adopting modern libraries and techniques ensures that the project adheres to current best practices in Rust development.

How to implement and why

  1. Update Cargo.toml:

    • Add or update dependencies for modern Rust HTTP client libraries such as reqwest.
    • Ensure that all dependencies are compatible with each other.
  2. Refactor src/bin/search_address.rs and src/bin/search_zipcode.rs:

    • Replace old HTTP client code with the new reqwest client.
    • Ensure that all API calls are updated to use the new client.
    • Handle errors and responses according to the new library's best practices.
  3. Update src/lib.rs:

    • Refactor any shared client logic to use the updated dependencies.
    • Ensure that the library's public API remains consistent and backward-compatible if possible.
  4. Testing:

    • Write new tests or update existing ones to cover the changes.
    • Ensure that all tests pass and that the new client behaves as expected.
  5. Documentation:

    • Update the README.md and any other relevant documentation to reflect the changes.
    • Provide examples of how to use the new client.

By following these steps, we ensure that the client is modernized, secure, and maintainable, aligning with the latest best practices in Rust development.

Test these changes locally

git checkout -b gitauto/issue-#5-254683b7-56b0-42f7-84a9-fba57c6a2f07
git pull origin gitauto/issue-#5-254683b7-56b0-42f7-84a9-fba57c6a2f07

@AppVeyorBot
Copy link

Build viacep-rs 1.0.110 failed (commit 7114ae6f25 by @gitauto-ai[bot])

@gstraccini gstraccini bot requested a review from guibranco July 9, 2024 02:55
@guibranco
Copy link
Owner

@gstraccini review

Copy link

gstraccini bot commented Jul 12, 2024

Reviewing this pull request.

Commits included:
SHA: 23d78a95eb339a1e837668cdcf0ad6b0433103a0
SHA: 6231337d358d3839a4bf66da1b6ee88fb2363906
SHA: 8b8f802e14cc87c2a1f09b1b4082ded9d92b625f
! 👀

@gstraccini gstraccini bot added the 🚦awaiting triage Awaiting triage label Jul 12, 2024
@guibranco
Copy link
Owner

@gstraccini review

Copy link

gstraccini bot commented Jul 12, 2024

Reviewing this pull request.

Commits included:
SHA: 23d78a95eb339a1e837668cdcf0ad6b0433103a0
SHA: 6231337d358d3839a4bf66da1b6ee88fb2363906
SHA: 8b8f802e14cc87c2a1f09b1b4082ded9d92b625f
! 👀

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Jul 12, 2024
@guibranco guibranco closed this Jul 17, 2024
@guibranco guibranco deleted the gitauto/issue-#5-254683b7-56b0-42f7-84a9-fba57c6a2f07 branch July 17, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚦awaiting triage Awaiting triage 🤖 bot Issue/Pull request created by bot size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants