Do not resolve by parameter name

guide42 · Jun 27, 2017 · 58e73c4 · 58e73c4
1 parent a103b2d
commit 58e73c4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,7 @@
 
   - PSR-11 support.
   - [BC-BREAK] Arguments are not revolved as parameter unless dollar sign is prefix.
+  - [BC-BREAK] Removed resolve by parameter name.
 
 ### 0.8.0
 

diff --git a/library/Registry.php b/library/Registry.php
@@ -177,8 +177,6 @@ private function buildContext(array $parameters, array $arguments) {
                 $context[$index] = $resolve($arguments[$name]);
             } elseif ($param->hasType() && !$param->getType()->isBuiltin() && isset($this->delegate[strval($param->getType())])) {
                 $context[$index] = $this->delegate[strval($param->getType())];
-            } elseif (isset($this->delegate[$name])) {
-                $context[$index] = $this->delegate[$name];
             } elseif ($param->isDefaultValueAvailable()) {
                 $context[$index] = $param->getDefaultValue();
             } elseif ($param->isOptional() && !$param->isVariadic()) {

diff --git a/spec/Suite/RegistrySpec.php b/spec/Suite/RegistrySpec.php
@@ -372,14 +372,6 @@ function __construct(Engine $engine, string $color='red') {
             expect($di->make(W16::class))->toBeAnInstanceOf(W16::class);
         });
 
-        it('creates a concrete class with delegate lookup the parameter name', function() {
-            $di = new Registry;
-            $di->offsetSet('left', new V8);
-            $di->offsetSet('right', new V8);
-
-            expect($di->make(W16::class))->toBeAnInstanceOf(W16::class);
-        });
-
         // require pdo-sqlite
         xit('creates a concrete class with no default values but optional', function() {
             $di = new Registry;