-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import_svg_as_forced_outline function #718
base: dev
Are you sure you want to change the base?
Conversation
292fd62
to
715753a
Compare
715753a
to
fac24ea
Compare
Here are a few high level things to consider:
|
Sure, might not get around to fulfilling all of those requests in the near future, but I'll aim to following the guidelines. Apologies for missing those the first time. Regarding ocpsvg, currently I'm using b123d features to connect the wires cleanly, so I think that would be more work than I'm willing and able to put in |
I've not studied the whole thing but it looks like what this PR accomplishes is pretty close to, or at least overlaps with, existing functionality in |
I'll have to read the source for make wire. All I know is that it didn't work for the faces I imported, and this makes some notable changes to the imported that I wouldn't want made by default for all shapes |
IIRC the SVG import crashes so there is no opportunity to fix the broken wires. |
Another way to approach this problem might be to enhance the SVG importer to enable a request for just Edges with no attempt to build Wires or Faces. With just the Edges, the |
Is there any data to reproduce this crash? |
Make importing unclean outlines easier. Works really well on the KiCad exports of two unrelated PCBs that I tested it on.